Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Updates and Mini Menu #1254

Merged
merged 29 commits into from
Jan 24, 2025
Merged

Display Updates and Mini Menu #1254

merged 29 commits into from
Jan 24, 2025

Conversation

mikepparks
Copy link
Contributor

@mikepparks mikepparks commented Jan 3, 2025 •
edited
Loading

This fixes a number of outstanding issues with the Display and related functions while introducing some new functionality.

Fixes & Updates

  • Adjusted a number of existing layouts in order to not render on the outside of the screen with certain displays.
  • Updated GPSprite objects to allow scaling
  • Improved autodetection of display modules and added a means to override the detected display type

New

  • Added a mini configuration menu to the Display screen structure.
    • This was a work in progress while completing work for the Event System (Event System Implementation #1247 ) in order to have a cleaner way of managing addon options/states without code duplication. Only a small number of features are currently supported in this menu, but more can be added in the future.
  • Introduced a new Screen Saver mode in addition to the default "display off" mode.
    • Screen saver modes: Snow, Bounce, Pipes, Toast
  • Added VLX & Sega 2P 6 button layout varieties.

@mikepparks
Initial commit for mini config menu
42bae49
@mikepparks
Implemented menu options and prepared methods for save functionality.
fa04c3a
@mikepparks
Merge branch 'OpenStickCommunity:main' into 20241130-minimenu
60edf8b
@mikepparks
Removed stdio init
5124bf8
@mikepparks
Merge branch '20241130-minimenu' of github.com:madgooselabs/GP2040-CE…
91a0a70 
… into 20241130-minimenu
@mikepparks
Added screen saver mode in addition to display timeout. Default is Di…
47ea2ee 
…splay Off (original behavior).

Added "snow", "bounce", "pipes", and "toast" screen savers.
drawSprite can now scale sprite data.
@mikepparks
Added VLX and Sega 2P 6 button layout variants
7df98c6 
Added button layout orientation feature to switch layouts for handedness
Updated Display config page to update enum definitions for i18n
@mikepparks
Added menu navigation helper function in prep for event system
049b846 
Added layout and menu action locale strings
@mikepparks
Adjustments to Arcade, Button Angled, and Capcom layouts to make them…
1615d1c 
… less likely to cut off on SH110X displays.
@mikepparks
Improved screen autodetection and manual override
000ab0b
@mikepparks mikepparks marked this pull request as draft January 3, 2025 22:14
@arntsonl
Copy link
Contributor

arntsonl commented Jan 8, 2025

Very excited for this one!

@mikepparks
Mostly implemented menu navigation, config change storage, and reboot…
582bbe5 
… events
@mikepparks
Full menu navigation implementation.
ba0503c 
Added timer for reboot cases.
@mikepparks
Increased storage size to 32k
7d875b9
@mikepparks
Added options to disable different components of the status bar on Bu…
4b6d633 
…ttonLayoutScreen.

Removed & deprecated input history addon remnants and migrated to Display options proper.
@mikepparks mikepparks changed the title Mini Config Menu for Display Display Updates and Mini Menu Jan 14, 2025
@mikepparks mikepparks marked this pull request as ready for review January 14, 2025 01:31
arntsonl
arntsonl approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!!! This is a pretty awesome feature and a bunch of good changes.

We'll have to make a note to ourselves that this bumps us from 16kb to 32kb for the PROM, since we were so close before

@arntsonl arntsonl merged commit 69f6d21 into OpenStickCommunity:main Jan 24, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikepparks @arntsonl